Upgrade to @ariakit, Modernize RRE, Part 1 #126
Conversation
devinmatte
changed the title
github-actions
bot
added
documentation
devinmatte
requested review from
idreyn,
vickymmcd,
austinjpaul,
mathcolo and
nathan-weinberg
as code owners
devinmatte
changed the title
|
@nathan-weinberg I want to finish removing |
| @@ -6,7 +6,7 @@ | |||
| "dev": "next dev", | |||
There was a problem hiding this comment.
As an aside (unrelated to the contents of this PR) does next dev work for you at this point? I'm getting a bizarre error:
~/t/regional-rail-explorer ❯❯❯ npx next dev modernize-rre ✱
warn - Port 3000 is in use, trying 3001 instead.
ready - started server on 0.0.0.0:3001, url: http://localhost:3001
/Users/ian/transitmatters/regional-rail-explorer/node_modules/typescript/lib/typescript.js:139
for (let i = startIndex ?? 0; i < array.length; i++) {
^
SyntaxError: Invalid or unexpected token
at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
which makes me think it's invoking an older version of Node without the ?? operator. Running next build works fine though so I'm set for testing purposes.
There was a problem hiding this comment.
I don't think I got next dev working either. But to be fair, a lot of stuff is in a weird in between.
At the end of this process I want to get up to nextJS 15.x and Node 22.x, which means everything is on a modern release and should all work together cleaner (and likely give better error messages when they don't). But first we gotta clean up reakit.
Since build works fine for now I think this is a "later" thing to fix imo
Motivation
#122
Changes
legacy-peer-deps=truefor now, with plans to remove afterreakitis gone, and nextjs is fully updatedTesting Instructions